Fix heap memory issue when processing attestations for altair #4404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
approved these changes
Aug 12, 2022
twoeths
force-pushed
the
tuyen/fix-heap-memory-issue
branch
from
1c123fc
to
9a2bb65
Compare
dapplion
suggested changes
Aug 12, 2022
twoeths
force-pushed
the
tuyen/fix-heap-memory-issue
branch
from
9a2bb65
to
9442a53
Compare
dapplion
approved these changes
Aug 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR #4294 causes the memory to increased a lot, the reason is we access
state.validators.get()on every indexed attestations (20_000 times per block), see #4397 (comment)Description
state.validators.getReadOnly()instead ofstate.validators.get()Closes #4397